Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds video caching feature #41

Merged
merged 6 commits into from
Dec 15, 2015
Merged

Adds video caching feature #41

merged 6 commits into from
Dec 15, 2015

Conversation

alistairmcmillan
Copy link
Collaborator

Please let me know if you'd like any changes to improve this PR.

As requested in issues #11, #24, #26, #40 and possibly others.

@alistairmcmillan
Merge branch 'cDima/master'
adbc0ab
@alistairmcmillan
Merge branch 'cDima/master'
ae84767
@alistairmcmillan
Merge branch 'cDima/master'
5a22bcb
@alistairmcmillan
Adding Cache Videos feature
899adc9 
- Checks whether videos are in cache folder
- If they are it plays them
- If they aren’t it plays from the network while at the same time
copying a saving a copy to a temp folder
- Once the copy has successfully downloaded it copies it from the temp
folder to the cache folder (we don’t want partially downloaded files in
the cache folder)
@alistairmcmillan
Remove crude debugging :)
feeb74b
@alistairmcmillan
Update ScreenSaverForm.cs
bcebea3 
Create cache folder if it doesn't exist.
@cDima
Copy link
Owner

cDima commented Dec 15, 2015

Nice approach, I'm wondering if it's easy to test on a bad connection.
Thanks!

On Mon, Dec 14, 2015 at 9:04 PM, Alistair McMillan <notifications@github.com

wrote:

Please let me know if you'd like any changes to improve this PR.

As requested in issues #11 #11,
#24 #24, #26
#26, #40

#40 and possibly others.

You can view, comment on, or merge this pull request online at:

#41
Commit Summary

  • Merge branch 'cDima/master'
  • Merge branch 'cDima/master'
  • Merge branch 'cDima/master'
  • Adding Cache Videos feature

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#41.

*Dmitry Sadakov *
Consultant – Web Technology | Gemini Systems | A&M | 600 Madison Ave| New
York, NY | Mobile +16468531955
sadakov.com | linkedin http://linkedin.com/in/sadakov | stackoverflow
http://stackoverflow.com/users/82054/cdima | github
https://github.com/cDima | g+ http://www.google.com/profiles/sadakov |
facebook https://www.facebook.com/sadakov | vk http://vk.com/sadakov |
skype:dmitry.sadakov

cDima added a commit that referenced this pull request Dec 15, 2015
@cDima
Merge pull request #41 from alistairmcmillan/CacheVideos
b5ef70c 
Adds video caching feature, off by default.
@cDima cDima merged commit b5ef70c into cDima:master Dec 15, 2015
@cDima
Copy link
Owner

cDima commented Dec 15, 2015

Thanks, merged @alistairmcmillan !

@alistairmcmillan alistairmcmillan deleted the CacheVideos branch January 20, 2016 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alistairmcmillan @cDima