Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeriodicTask.stop() does not stop the scheduled task #3

Closed
vlabzdev opened this issue Sep 2, 2015 · 3 comments · Fixed by #4
Closed

PeriodicTask.stop() does not stop the scheduled task #3

vlabzdev opened this issue Sep 2, 2015 · 3 comments · Fixed by #4

Comments

@vlabzdev
Copy link

vlabzdev commented Sep 2, 2015

Hi,
I started a task and I had an condition inside the task function to call the PeriodicTask.stop() to stop it after the condition matches. However I see that the task does not seem to stop.

Please let me know if there is any issue related to this.

Regards,
Akshay
@cGuille
Copy link
Owner

cGuille commented Sep 2, 2015

Hello,

I'm surprised someone is using this project. Thanks for your feedback!
I think I understood why this does not work. I am going to fix it.

Regards,
Guillaume.

cGuille added a commit that referenced this issue Sep 2, 2015
@cGuille
Fix: #stop() calls within the task
24f538b 
Fix #3
@cGuille cGuille mentioned this issue Sep 2, 2015
Merged
@cGuille cGuille closed this as completed in #4 Sep 2, 2015
@cGuille
Copy link
Owner

cGuille commented Sep 2, 2015

Can you check if the version 0.1.1 resolve your issue?

@vlabzdev
Copy link
Author

vlabzdev commented Sep 2, 2015

Thanks Guille for the quick turnaround. Will check and update.

Regards,
Akshay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: #stop() calls within the task cGuille/periodic-task
2 participants
@cGuille @vlabzdev