add: exponential backoff #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2022 18:08
|
過去数週間分のエラーログをみたところ以下のメソッドもRetryの仕組み追加しました UpsertFinding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deadlockの対処法としてMySQL公式ドキュメントを参考にアプリ側にリトライの仕組みを導入しようと思います。
全体に導入するというより、まずは実際にDeadlockが発生している処理にしぼって設定する方針です。
Backoffの実装は以下のライブラリを使いました。
https://pkg.go.dev/github.com/cenkalti/backoff/v4
リトライのロジックは↓準拠のものになっています。
https://en.wikipedia.org/wiki/Exponential_backoff