Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default policy #360

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: default policy #360

merged 1 commit into from
Apr 16, 2024

Conversation

gassara-kys
Copy link
Collaborator

デフォルトのポリシーが意図した動作になってなかったので修正します

Copy link

PR Analysis

Main theme

Bug fix

PR summary

The PR introduces a fix in the createDefaultRole function to address the issue related to regular expressions patterns for findingEditor role. The updated patterns now consider "^" to match the beginning of the string correctly.

Type of PR

Bug fix

PR Feedback:

General suggestions

Consider adding comments to explain the purpose of the regular expression patterns assigned to each role in the createDefaultRole function. This will improve code readability and help other developers understand the logic behind the role definitions.

Code feedback

- relevant file: pkg/server/project/project.go
  suggestion: "Consider adding comments to explain the purpose of each role's regular expression pattern."
  relevant line: "+		findingEditor: viewerActionPtn + \"|^finding/.+|^alert/.+\","

Security concerns:

no

Copy link

セキュリティレビューを実施しました。
特に問題は見つかりませんでした👏

By RISKEN review

Copy link
Contributor

@senk8 senk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gassara-kys gassara-kys merged commit 3900380 into master Apr 16, 2024
5 checks passed
@gassara-kys gassara-kys deleted the fix-policy branch April 16, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants