Use the hashKey provided in config #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of this library would perform some actions using the provided hashKey and others using the default `id`. This commit makes the behaviour more consistent, and will always use the provided hashKey (while still defaulting to `id` of course!).
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of this library would perform some actions using the
provided hashKey and others using the default
id.This commit makes the behaviour more consistent, and will always use the
provided hashKey (while still defaulting to
idof course!).Any issues let me know, but I haven't changed much and have tried to follow the style guidelines you've used.
This PR should resolve #35