-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9] Add pre-shared keys generation #17
Open
sancho20021
wants to merge
11
commits into
cab404:master
Choose a base branch
from
sancho20021:9-preshared-keys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: No functionality to avoid specific IPs when generating IPs for peers. Solution: Add `ignore` command (only IPv4 for now).
Problem: Current implementation is quite hard to understand. Solution: Store reserved peer IPs in hashmap.
Problem: Ignored ranges and multiple IP networks introduced difficulties in Peer ID -> IP mapping. Solution: Allocate new peer IPs without using id and store them in PeerInfo.
Problem: no tests for ignoring ip ranges. Solution: add tests. Find bugs and fix them.
Problem: IP range is allowed to be ignored even if it contains assigned IPs. Solution: Abort ignore operation if necessary.
11 avoid specific ips
Solution: Add a map in Wireguard Networkinfo that contains pre-shared keys for each pair of hosts. Add command that generates keys on demand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pre-shared keys for each pair of hosts.
Fixes #9
Notes
Serialization
I didn't manage to serialize map of tuples to
Warnings
How to fix this?