[RFC] Multiple Cabals Continuation #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: nikolaiwarner <nikolaiwarner@users.noreply.github.com>
yaay it's a lot shorter, and kind of makes sense if we have `cabal-client` as a module
the users object, returned from `cabal-core/views/users.js:getAll()` is empty at first start (nothing has been recorded in the kappa-core db yet), so the iteration in updateLocalKey will never occur. thus we *at least* set the key we've gotten (since we will always know that) and then try to find the name as registered in the database
Closed
This was referenced Nov 7, 2018
Closed
Closed
|
Let's call it "database version" or something then, since it's only being used to make storage decisions.
|
hackergrrl
reviewed
Nov 13, 2018
|
|
||
| var cabal = Cabal(args.db, args.key) | ||
| if (args.new) { | ||
| var key = crypto.keyPair().publicKey.toString('hex') |
hackergrrl
reviewed
Nov 13, 2018
package.json
Outdated
| @@ -1,17 +1,20 @@ | |||
| { | |||
| "name": "cabal", | |||
| "version": "5.0.0", | |||
| "version": "5.0.1", | |||
There was a problem hiding this comment.
Can we do version bump in a separate PR?
|
after some discussions in #cabal-club we decided that it's better to get this into master and keep the show going we still have bugs with multi-cabal, but the config stuff is really nice, so i'm going to try to put multi-cabal behind an tasks
|
i also added --join to join a cabal while disregarding the config (not sure about that one, but i felt the need for it w/ multi) closes #70
to keep going we'll hide multi-cabal behind a flag, and keep on working on its bugs in secret :3
|
we're now printing saved aliases |
this allows us a cabalist to print out which saved cabal aliases they have. a good memory aid for the chatting individual part of #70
--clear clears all aliases --forget forgets the specified alias
also: * improve cabal's config handling and make it more robust
nikolaiwarner
approved these changes
Nov 15, 2018
| @@ -84,165 +95,246 @@ function NeatScreen (cabal) { | |||
| else return | |||
| this.bus.emit('render') | |||
| }) | |||
|
|
|||
| // move between window panes with ctrl+j | |||
| this.neat.input.on('alt-n', () => { | |||
There was a problem hiding this comment.
alt-n still doesnt work for me on mac terminal ... but we can solve it after this lands
hackergrrl
reviewed
Nov 15, 2018
that lil sucker just decided to appear, not intended! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a continuation of nick's pr #84
i fucked up my branches so here we are with a new pr