Build prometheus.Histogram instead of Observer #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unprecise usage of `prometheus.Observer` instead of `prometheus.Histogram` may be misleading, since both `Histogram` and `Summary` interfaces embed the `Observer` interface. This is a breaking change since previous code won't compile with this version, so there's no better moment (except for v2) for doing this than going v1.
colega
force-pushed
the
colega/build-histogram-instead-of-observer
branch
from
be76c49
to
94d7258
Compare
simonsargeant
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unprecise usage of
prometheus.Observerinstead ofprometheus.Histogrammay be misleading, since bothHistogramandSummaryinterfaces embed theObserverinterface.This is a breaking change since previous code won't compile with this version, so there's no better moment (except for v2) for doing this than going v1.
Solves https://github.com/cabify/gotoprom/issues/21 although without offering a backwards compatible mechanism because of how packages are loaded and initialized.