Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP-1595: Fixing screen reader issue with hidden span tags #424

Merged

Conversation

GavCookCO
Copy link
Contributor

@GavCookCO GavCookCO commented Mar 27, 2024

Description

Screenshot 2024-03-27 at 11 21 32

In the table above, the links to add/change details have hidden span tags attached to them in order to aid screen readers by providing better descriptions of what the links are doing. These span tags contained uri components so when the screen reader reached them it would announce "update slash organisation slash name", etc.

These uri components have been formatted to remove the slashes. There was also some concern over dashes but I have tested these and the screen reader handles them fine so I have left those in place.

Ticket # and link
GAP-1595

Summary of the changes and the related issue. List any dependencies that are required for this change:

see above.

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@ConorFayleTCO ConorFayleTCO merged commit 5045d1f into develop Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants