Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shards to work well with ordered_set tables. #4

Closed
cabol opened this issue Mar 15, 2016 · 1 comment
Closed

Fix shards to work well with ordered_set tables. #4

cabol opened this issue Mar 15, 2016 · 1 comment

Comments

@cabol
Copy link
Owner

cabol commented Mar 15, 2016

Currently, shards doesn't behaves well when tables are ordered_set type, because results are sorted per shards, but not at global level (across all configured shards). The same problem happens with shards_dist across different node.

NOTE: This might be tricky to solve.
@cabol
Copy link
Owner Author

cabol commented Jul 22, 2016 •
edited
Loading

There is a workaround for this issue, and it is when a new ordered_set is created, force the number of shards to one, so with a single shard it will behave as a normal ETS ordered_set. The downside is that we would lose all benefits of shards, in case of ordered_set wouldn't make any difference to ETS. But for now, this fix will keep the correct behaviour of ordered_set – a better solution might be implemented afterwards.

cabol added a commit that referenced this issue Jul 29, 2016
@cabol
[#4] Workaround – force the number of shards to one in case of `order…
80d8106 
…ed_set`.
@cabol cabol mentioned this issue Jul 29, 2016
Closed
@cabol cabol closed this as completed Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cabol