-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 5.3 Shift #2195
Laravel 5.3 Shift #2195
Conversation
The Laravel framework adopts the PSR-2 coding style in version 5.1. Laravel apps *should* adopt this coding style as well. Read the [PSR-2 coding style guide][1] for more details and check out [PHPCS][2] to use as a code formatting tool. [1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md [2]: https://github.com/squizlabs/PHP_CodeSniffer
Laravel 5.3 now stores Routes in a top-level `routes` folder and separates them into API, console, and web files.
ℹ Laravel 5.3 updated the |
ℹ Laravel 5.3 no longer includes the |
❌ I was not able to update your |
❌ I was not able to update your |
❌ I was not able to update your |
❌ Laravel 5.3 now includes a top-level |
❌ I could not upgrade the following configuration files since they differed from the 5.2 defaults. You need to compare these configuration files against the Laravel 5.3 configuration files and merge any changes:
|
❌ I could not upgrade the following project files since they differed from the 5.2 defaults. You need to compare these project files against the default Laravel 5.3 versions and merge any changes:
|
❌ Laravel 5.3 has a development dependency for |
❌ Laravel 5.3 has a development dependency for |
❌ Laravel 5.3 has a development dependency for |
❌ Laravel 5.3 You should review the following usages of
|
❌ In Laravel 5.3, Eloquent scopes now respect the leading boolean of scope constraints. If you are starting your scope with an You should review the following usages of
|
❌ In Laravel 5.3, the You should review the following usages of
|
❌ The Query Builder returns collections, instead of plain arrays, in Laravel 5.3. You will need to upgrade your code to use collections or chain the You should review the following usages of Query Builder:
|
ℹ If you are using Queues, you no longer need to specify the If you are using the |
ℹ Laravel 5.3 updated several of the default assets as well as adding support for Vue.js. If you are using Laravel to compile assets you may want to review the latest versions of |
⚠ Laravel 5.3 added configuration for your application name in |
[ci skip] [skip ci]
'order' => 'int', | ||
'group_id' => 'int', | ||
'enabled' => 'bool', | ||
'description' => 'required|string', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be nullable|string
, otherwise you're forced to provide a description for components when creating them through the API (even though you can have an empty description when creating or editing them in the dashboard).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Feel free to submit a PR :)
The command is now called CreateComponentCommand
.
This pull request includes the changes for upgrading to Laravel 5.3. Feel free to commit any additional changes to the
laravel-5.3-shift
branch.Before merging, you should:
laravel-5.3-shift
branchcomposer update
(if the pre-commands fail, add--no-scripts
)If you would like more help with your upgrade, check out the new human services from Laravel Shift.