Add missing silent paramater, and cast status to Int before comparing #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooksuk
reviewed
Mar 1, 2017
|
Hmm I thought so, however some updates created via the API seem to have strings for statuses. I had an incident with a status of 4 in the DB but if I dumped status in that comparison it was definitely a string. |
jbrooksuk
approved these changes
Mar 2, 2017
|
I couldn't merge this on my phone, sorry for the delay! |
|
No worries! Glad to have been able to contribute 👍🏼 |
|
If you're into design stuff, we're looking for a new dashboard 😜 I hope to see more contributions! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appears that if an incident has no updates and you check the parent incident's status, it can often be a string rather than an Int. I noticed this was the case with incidents being created and updated via the Cachet API and a number of popular third party tools/monitors.