Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build assets automatically #51

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Build assets automatically #51

merged 5 commits into from
Oct 12, 2024

Conversation

jbrooksuk
Copy link
Member

No description provided.

@Ionys320
Copy link

I also strongly suggest to add the build folder to .gitignore after deleting the files. I think there is no need to keep a track on builded files.

@jbrooksuk
Copy link
Member Author

@Ionys320 I might be dumb here, but won't adding the build directory to .gitignore prevent us from being able to commit them automatically?

@Ionys320
Copy link

@jbrooksuk When a file/folder is tracked by git (by being commited), adding it to .gitignore doesn't ignore it until the file is removed from the system (by deleting it and commit the deletion). After this only, creating the folder/file will not track it anymore!

@jbrooksuk
Copy link
Member Author

@Ionys320 but we do want to ship Cachet with the compiled assets.

@jbrooksuk jbrooksuk merged commit 7a87a21 into main Oct 12, 2024
@jbrooksuk jbrooksuk deleted the build-assets branch October 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants