Add supporting independent expenditures for candidates #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
adborden
force-pushed
the
tdooner-add-ie-supporting
branch
from
3a3aacd
to
b879f24
Compare
adborden
changed the title
|
This is ready for review. |
[Closes caciviclab/disclosure-backend-static#95] In that issue, Suzanne noticed that we feature "Expenditures Opposing Candidate" on the candidate's detail page, however we don't include Expenditures supporting candidate. Not many candidates have independent expenditures, but those that do -- Huber Trenado, Jumoke Hodge, and James Harris (three candidates for the school board) -- have quite a lot (more than $100k each). This also makes the section conditionally hidden if there are no independent expenditures for/against the candidate. I'm not confident this is always the right move (it might be nice for a user to know that a candidate is receiving no IE money) but it seems like a reasonable first step since most candidates have zero IE money.
It seems as though the test suite fails if these candidates are not linked from the pages?
adborden
force-pushed
the
tdooner-add-ie-supporting
branch
from
5516900
to
3b9509d
Compare
|
Rebased. |
|
Resolves #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased changes from #63 onto the
feature/update-financebranch. This is just waiting on that to be merged.