-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot match current iteration key ETag #58
Comments
Hello @jpds thank you for this feedback and the detailed issue. |
I built the linked PR with:
However, the ETag still does not seem to be cached, I tripled tested this with Firefox/Chromium/curl:
curl always returns:
|
@jpds I updated the codebase in the PR and added a unit test about this feature. 🤞 |
@darkweak Thank you very much for the fix. I can confirm that the logs say:
However, every request now seems to request revalidation:
Is there a configuration option I'm missing? Edit: I've also just discovered that the backend I'm using also does caching and here's the logic they use: https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/67b1457c77d930cd12f83f5cf07ec7f2376fa00c/src/api/s3/get.rs#L52-L89 |
@jpds I updated the debug message to display the current validator (that contains the |
None of my client requests will be sending ETags, I believe - here's the new log output:
All the ETags involved are coming from the backend server - hence I was wondering if there was some mismatched expectations in what the backend is proposing to Souin. Edit: and the backend in question is a static S3 bucket with simple web content: https://garagehq.deuxfleurs.fr/documentation/cookbook/exposing-websites/ - hence I was hoping that Caddy could cache the latest copy of this content locally without having to ask the backend storage servers what was available. |
I've been playing with With an ETag, curl bounces between REQUEST-REVALIDATION and UNCACHEABLE-STATUS-CODE:
If I use the older
|
Hey @jpds sorry for the delay. |
@darkweak Now it is all working - perfectly 🎉 . Seeing hits everywhere. |
I have this plugin configured as follows:
However, every time I hit one of the domains fronted by this configuration, I see this in the logs:
And the
ETag
never changes betweencurl
runs, however in the logs I then see:The text was updated successfully, but these errors were encountered: