Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): etags mismatch #357

Merged
merged 9 commits into from
Aug 17, 2023
Merged

fix(chore): etags mismatch #357

merged 9 commits into from
Aug 17, 2023

Conversation

darkweak
Copy link
Owner

@darkweak darkweak commented Aug 9, 2023

@darkweak darkweak added the bug Something isn't working label Aug 9, 2023
@darkweak darkweak self-assigned this Aug 9, 2023
@darkweak darkweak merged commit a3d23bc into master Aug 17, 2023
20 of 21 checks passed
@let4be
Copy link

let4be commented Aug 19, 2023

Hi!

I was going through the code and noticed that we no longer call .Revalidate() if response was found in the cache even if it's detected that Revalidation is required...

Is this the intended behavior?

@low613
Copy link

low613 commented Aug 20, 2023

Hi,

It seems that this PR also changed some debug level logging to info level.
This is filling up the logs with a lot of garbage when serving binary files.

Is this intended?

@darkweak darkweak deleted the fix/chore/etags-mismatch branch August 22, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEAD gives zero-sized Content-Length Cannot match current iteration key ETag
3 participants