downgrade minimum Go version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
godirective is set to the current version on the system where the module was created. It defines the minimum accepted version of Go to set the language semantics. This dep forced certmagic minimum Go to increase to 1.22, which cascaded to Caddy requiring Go 1.22. None of them require the upgrade. Using lower version in this line does not block building with newer Go versions. It does cause pain in building, as reported on various modules trying to use thebuildervariant of the Caddy docker image.It's best to keep this at 1.21 for now, until the new Docker images have the newer version of Go, then we can move this value up (if important).