Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port django-oath2-provider for django 1.4/python 3.3 #39

Open
seanh1414 opened this issue Sep 10, 2013 · 1 comment
Open

Port django-oath2-provider for django 1.4/python 3.3 #39

seanh1414 opened this issue Sep 10, 2013 · 1 comment
Labels
compatibility enhancement

Comments

@seanh1414
Copy link

I completed this locally (and i've never submitted any code changes so not quite sure how that works) most of it was around dict.iteritems -> dict.items, a few OExcept, e: needing to become OExcept as e:, reduce needing to be imported from functools and a bunch others. I will do a diff sometime of my final library and report the changes i made. (Unless someone wants to be kind and point me towards a how to contribute..)
@eculver
Copy link
Contributor

eculver commented Oct 25, 2013

Hi, @skstudios. I'm glad you were kind enough to do this and I'd be glad to help you get your changes into the project. On a high level, here are the steps that may help you to get started contributing:

  1. Fork the project as mentioned here
  2. Integrate your changes into the existing codebase (as you've already done it seems)
  3. Commit your changes to your fork as mentioned here
  4. Submit a pull request as mentioned here

If you have any issues, feel free to contact me (e at eculver dot io) or post to our newly created mailing list here.

@wm3ndez wm3ndez mentioned this issue Dec 8, 2013
Closed
@blag blag mentioned this issue Oct 23, 2015
Open
joestump pushed a commit to sprintly/django-oauth2-provider that referenced this issue Jan 18, 2017
@brandond @clintonb
Make provider.oauth2 compatible with Django >= 1.9 (caffeinehit#39)
f5cd40a 
From the release notes:
```All models need to be defined inside an installed application or declare an explicit app_label. Furthermore, it isn’t possible to import them before their application is loaded. In particular, it isn’t possible to import models inside the root package of an application.```

Fixes error "django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet." when starting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eculver @seanh1414