Removing need to client_secret during password grants for public clients #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in issues caffeinehit#21 and caffeinehit#25. This provides a more rigerous check of the circumstances required for the client_secret to forgone.
added 2 commits
September 14, 2013 14:16
Public clients often wish to have shorter expieration times
|
I think this is a worthwhile addition. I'm going to see if I can reproduce the issue @ankitml ran into and review. Hopefully we can get this merged soon. Thanks @adamcharnock. |
eculver
added a commit
that referenced
this pull request
Oct 25, 2013
|
I couldn't reproduce @ankitml's issue and given that the mention was of "kwagrs" instead of "kwargs" and because that string is nowhere in the source, I think it's probably safe to say that there was something else weird going on there. @ankitml, Please correct me if I'm wrong though or if you are still having issues. |
|
I cleaned things up (PEP8) and flattened the tree, but things applied cleanly and this is officially in master now. Thanks again @adamcharnock! |
|
Awesome. Would love to see go into PyPI soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issues #21 and #25. This provides a more rigerous check
of the circumstances required for the client_secret to forgone.
(includes tests)