Convert node app to github action #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caffo
reviewed
Sep 20, 2022
| @@ -161,7 +157,7 @@ async function buildNewMarkup(data) { | |||
| let markup = ` | |||
| <li id='${entry.node}' style='display: inline;' lazy='loaded'> | |||
| <div class='cover'> | |||
| <img src='${entry.cover.replace('src/', '')}' /> | |||
| <img src='${entry.cover.replace('out/', '')}' /> | |||
There was a problem hiding this comment.
I don't get what this is doing. It's removing out from the entry.cover? Why it would out be there? (I see you using it at 144
There was a problem hiding this comment.
We need out while saving and checking the existence of covers because we're in the working dir, which is root. When adding image references to the new markup we need to remove out because the HTML file is already inside of out itself.
marcosvafilho
force-pushed
the
convert_to_github_action
branch
from
c913dd1
to
8f95bd8
Compare
marcosvafilho
force-pushed
the
convert_to_github_action
branch
from
8f95bd8
to
a3dc88e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.