Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Contact form not working #976

Closed
zakiya opened this issue Jul 11, 2023 · 7 comments
Closed

Bug: Contact form not working #976

zakiya opened this issue Jul 11, 2023 · 7 comments
Assignees

Comments

@zakiya
Copy link
Collaborator

zakiya commented Jul 11, 2023

Urls where issue was found

designsystem.webstandards.ca.gov

designsystem.webstandards.ca.gov/contact-us

Steps to reproduce

Fill out the form and hit submit

Expected result

Submission appears at https://airtable.com/app4B5KqaCTSHAdCS/tbliV5kSgz7jBnIyT/viwDkwTUo3wZOqYhF?blocks=hide
Emails are sent to Yesenia and Chach.

Acceptance criteria

  • Form is successfully submitted to Airtable
  • If possible, create an automated test to catch the issue if the API fails again.
  • I think the emails should go to Yesenia and Jon at this point since Chach is no longer active on this project.
  • The Airtable Base needs some clean up
  • Add information on the contact form to the root-level README so developers don't have to dig for documentation.
  • Stop using Aaron's Airtable API Key since it will stop working February 1st 2024. Airtable recommends using OAuth instead.

Optional criteria

  • Filter out xss submissions on the server side

CC:
@chachasikes @YeseniaGtz

@xjensen
Copy link
Collaborator

xjensen commented Jul 12, 2023

The form is working again. Aaron's Airtable Personal Access Token was disabled along with his account. Swapping to another Personal Access Token fixed the issue.

These Airtable Personal Access Tokens will not be depreciated on 2/1/2024; they're removing a different type of API key. Nonetheless, it's still a good idea to migrate to OAuth, as this ticket demonstrates.

The OAuth migration will require some real work. It's a nice little project.

@YeseniaGtz
Copy link
Collaborator

YeseniaGtz commented Jul 12, 2023 via email

@zakiya
Copy link
Collaborator Author

zakiya commented Jul 12, 2023

Here's a quote from the email I got about API keys

The timeline for the Airtable API key deprecation is below:

February 2023: Provided API Key deprecation notice
August 1st, 2023: Users will no longer be able to create new API keys
February 1st, 2024 (next year): Existing API keys cannot be used to access the Airtable API

I'll forward you the whole email @xjensen

@xjensen
Copy link
Collaborator

xjensen commented Jul 12, 2023

Got the email, thanks!

Aaron already did the work to replace the legacy API key with the newly supported Personal Access Token. I got my info about the Personal Access Tokens at this page. I believe he included this change when he converted the FaaS from Azure to AWS.

It's still a problem though, because his token expired when he left. (No fault of his, of course. Now we know.) So OAuth is still on the table as essential work IMO.

@zakiya
Copy link
Collaborator Author

zakiya commented Dec 28, 2023

@xjensen Have you had time to work on OAuth? Should I assign to someone else?

@xjensen
Copy link
Collaborator

xjensen commented Dec 28, 2023

@zakiya Nope, haven't worked on OAuth integration of the form.

At this point, I imagine it would be easier to just get a new Personal Access Token from our shared odi-engineering Airtable service account, so that it's not tied to my account. That would alleviate a lot of the concerns I had before about continuity of service.

But happy to look into it if OAuth is still desired.

@zakiya zakiya assigned zakiya and unassigned xjensen Dec 28, 2023
@zakiya zakiya mentioned this issue Dec 29, 2023
@zakiya
Copy link
Collaborator Author

zakiya commented Dec 29, 2023

We removed the contact forms from the design system. Closing.

@zakiya zakiya closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants