Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(api): normalize the api path placeholder #334

Merged
merged 2 commits into from
Jan 30, 2018

Conversation

supereagle
Copy link
Member

What this PR does / why we need it:

Normalize the api path placeholder to be lowercase.

Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):

Fixes #333

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

@caicloud-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2018
@supereagle
Copy link
Member Author

/assign @Superxi911

@supereagle
Copy link
Member Author

/lgtm

@caicloud-bot
Copy link
Collaborator

@supereagle: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@supereagle supereagle merged commit b85447f into caicloud:master Jan 30, 2018
@supereagle supereagle deleted the refact-api-path-placeholder branch January 30, 2018 10:37
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supereagle

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize the api path placeholder
3 participants