Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #325 into master #340

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

supereagle
Copy link
Member

What this PR does / why we need it:

Cherry pick #325 into master.
#325: refact(event): cleanup ETCD related doc, config, etc..

Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):

Fixes #

Special notes for your reviewer:

/cc @bbbmj

Release note:

NONE

@caicloud-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2018
@bbbmj
Copy link
Member

bbbmj commented Feb 6, 2018

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2018
@supereagle
Copy link
Member Author

/approve

@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbbmj, supereagle

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2018
@caicloud-bot
Copy link
Collaborator

Automatic merge from submit-queue.

@caicloud-bot caicloud-bot merged commit 2c9ad53 into caicloud:master Feb 6, 2018
@supereagle supereagle deleted the cherry-pick-325 branch February 6, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants