Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not listen port for https if no ssl configured #15

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

hicaistar
Copy link

@hicaistar hicaistar commented Jan 19, 2021

fix regression caused by kubernetes#4439

What this PR does / why we need it:

when creating an ingress without ssl cert, nginx will still listen on 442 for the server, which is not expected.
what we got:

                listen 80  ;
		listen [::]:80  ;

		listen 442 proxy_protocol  ssl http2 ;
		listen [::]:442 proxy_protocol  ssl http2 ;

what we expect:

                listen 80  ;
		listen [::]:80  ;

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@caicloud-bot caicloud-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 19, 2021
@hicaistar
Copy link
Author

/cc @hanxueluo

@hicaistar
Copy link
Author

/release-note-none

@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: whalecold

Assign the PR to them by writing /assign @whalecold in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 19, 2021
@hanxueluo hanxueluo changed the title fix: hide https listener for servers without ssl cert fix: do not listen port for https if no ssl configured Jan 19, 2021
@hanxueluo hanxueluo merged commit d63f12e into caicloud:controller-v0.43 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants