Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model info loaded 653 #654

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

gabe-l-hart
Copy link
Collaborator

What this PR does / why we need it:

Closes #653

This PR adds a new loaded field to the output of each model info block behind the InfoServicer's model info endpoint/rpc

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

caikit#653

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
caikit#653
Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
caikit#653
Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabe-l-hart gabe-l-hart merged commit c5a6a17 into caikit:main Jan 31, 2024
8 checks passed
@gabe-l-hart gabe-l-hart deleted the ModelInfoLoaded-653 branch January 31, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose loading status in /info/models
2 participants