Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced bignum with long #5

Merged
merged 1 commit into from
May 20, 2014
Merged

replaced bignum with long #5

merged 1 commit into from
May 20, 2014

Conversation

hallas
Copy link

@hallas hallas commented Apr 30, 2014

No description provided.

@hallas
Copy link
Author

hallas commented Apr 30, 2014

Hey. We have some problems with using your repo with 0.11, this will fix that, while maintaining the functionality of your repo.

@hallas
Copy link
Author

hallas commented Apr 30, 2014

Also it appears you should fix the travis settings not to run with 0.9 but 0.11 instead :)

@cainus
Copy link
Owner

cainus commented May 3, 2014

Thanks! I fixed the travis settings, confirming your bug. I'm not 100% sure about using Long vs other possible solutions (because I haven't done any performance testing on a js-only solution), but if you give me a few more days, I think I can get this sorted.

@hallas
Copy link
Author

hallas commented May 3, 2014

Thank you :)

@mronager
Copy link

Hi,
Just wondering what the status is for this pr?

cainus added a commit that referenced this pull request May 20, 2014
replaced bignum with long
@cainus cainus merged commit f1bd25b into cainus:master May 20, 2014
@cainus
Copy link
Owner

cainus commented May 20, 2014

Sorry about the slowness on this... I've just been really busy lately. Thanks for the contribution. I didn't have a chance to test the performance versus other possible solutions, but I can do that later if we run into performance issues.

@cainus
Copy link
Owner

cainus commented May 20, 2014

change just published in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants