Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
Object(x) !== x
is a terse idiom for detecting if something is a primitive valueI removed the handling for
schema instanceof String
since it seems like that case should either be extended toschema instanceof Boolean
andschema instanceof Number
or removed entirely, with the second option being simpler. Further, there was not a test on it.If you want the same behavior for
undefined
without accepting these changes, the added test will pass if you change=== null
on L48 to== null
.