Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current development crashes when loaded in Rider #276

Closed
nils-a opened this issue Sep 6, 2022 · 1 comment · Fixed by #277
Closed

Current development crashes when loaded in Rider #276

nils-a opened this issue Sep 6, 2022 · 1 comment · Fixed by #277
Assignees
@nils-a
Labels
Bug
Milestone
4.0.0

Comments

@nils-a
Copy link
Member

nils-a commented Sep 6, 2022

This is a regression from the changes I made in 33bbe7b.
Specifically, calling Dispose() on an IProject was a rather bad idea.
@nils-a nils-a self-assigned this Sep 6, 2022
nils-a added a commit to nils-a/cake-rider that referenced this issue Sep 6, 2022
@nils-a
(cake-build#276) removed the calls to IProject.Dispose()
0e1421c 
Also, enabled debugging the backend (Rider) part of the plugin
@nils-a nils-a mentioned this issue Sep 6, 2022
Merged
nils-a added a commit to nils-a/cake-rider that referenced this issue Sep 6, 2022
@nils-a
(cake-build#276) removed the calls to IProject.Dispose()
87a61b5 
Also, enabled debugging the backend (Rider) part of the plugin
nils-a added a commit that referenced this issue Sep 6, 2022
@nils-a
Merge pull request #277 from nils-a/feature/GH-276
b731597 
(#276) removed the calls to IProject.Dispose()
@nils-a nils-a added the Bug label Sep 6, 2022
@nils-a nils-a added this to the 4.0.0 milestone Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

🎉 This issue has been resolved in version 4.0.0 🎉
The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nils-a nils-a

Labels
Bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

(#276) removed the calls to IProject.Dispose() nils-a/cake-rider
1 participant
@nils-a