Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check in InfoFeature #3893

Merged
merged 3 commits into from
Jun 12, 2022
Merged

Conversation

Jon-Kjar
Copy link
Contributor

@Jon-Kjar Jon-Kjar commented Jun 9, 2022

Just noticed that one of the features had a null check but no tests associated. And that there was another feature that did not have that null check so added that with an associated check.

Closes #3894

@dnfadmin
Copy link

dnfadmin commented Jun 9, 2022

CLA assistant check
All CLA requirements met.

@augustoproiete augustoproiete linked an issue Jun 12, 2022 that may be closed by this pull request
@augustoproiete augustoproiete self-requested a review June 12, 2022 20:46
@augustoproiete augustoproiete changed the title Added null check in InfoFeature some checks Add null check in InfoFeature Jun 12, 2022
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@augustoproiete augustoproiete merged commit af9599b into cake-build:develop Jun 12, 2022
@augustoproiete
Copy link
Member

@Jon-Kjar your changes have been merged, thanks for your contribution 👍

@cake-build cake-build deleted a comment from FreshKhalifa Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guard against null Console instance on InfoFeature
4 participants