Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize Contributors #2507

Closed
cake-contrib-bot opened this issue Sep 21, 2022 · 5 comments · Fixed by #2508
Closed

Synchronize Contributors #2507

cake-contrib-bot opened this issue Sep 21, 2022 · 5 comments · Fixed by #2508
Assignees
@pascalberger

Comments

@cake-contrib-bot
Copy link
Contributor

The Cake.AddinDiscoverer tool has discovered that the list of contributors has changed.
cake-contrib-bot added a commit to cake-contrib-bot/website that referenced this issue Sep 21, 2022
@cake-contrib-bot
(cake-buildGH-2507) Create contributors.json
9f2a0a9
cake-contrib-bot added a commit to cake-contrib-bot/website that referenced this issue Sep 21, 2022
@cake-contrib-bot
(cake-buildGH-2507) Create contributors.yml
ffa3307
@cake-contrib-bot cake-contrib-bot mentioned this issue Sep 21, 2022
Merged
@Jericho
Copy link
Contributor

Jericho commented Sep 22, 2022

@pascalberger : this is the result of a new AddinDiscoverer feature which satisfies your request to maintain the list of contributors in convenient yaml/json files.

@pascalberger pascalberger self-assigned this Sep 26, 2022
augustoproiete pushed a commit to cake-contrib-bot/website that referenced this issue Jan 25, 2023
@cake-contrib-bot @augustoproiete
(cake-buildGH-2507) Create contributors.json
484b4ed
augustoproiete pushed a commit to cake-contrib-bot/website that referenced this issue Jan 25, 2023
@cake-contrib-bot @augustoproiete
(cake-buildGH-2507) Create contributors.yml
336eab4
augustoproiete pushed a commit to cake-contrib-bot/website that referenced this issue Jan 25, 2023
@cake-contrib-bot @augustoproiete
(cake-buildGH-2507) Create contributors.json
4295c10
augustoproiete pushed a commit to cake-contrib-bot/website that referenced this issue Jan 25, 2023
@cake-contrib-bot @augustoproiete
(cake-buildGH-2507) Create contributors.yml
e67464f
@augustoproiete
Copy link
Member

Very nice @Jericho! Thanks

Would you mind moving the files to /contributors instead of /maintainers? That simplifies our build process (which is trying to parse the contributors.yml as if it had the same format as the other maintainer.yml)

I already amended the PR #2508 to store the files in the new folder name, so you'd need to update Cake.AddinDiscoverer to reflect that for future updates.

@Jericho
Copy link
Contributor

Jericho commented Jan 25, 2023

Sure, no problem.

@Jericho Jericho mentioned this issue Jan 25, 2023
Closed
@Jericho
Copy link
Contributor

Jericho commented Jan 25, 2023

Done. Cake.AddinDiscoverer 4.7.0 is being published and will be in prod within 30 minutes or so. Feel free to merge #2508

@augustoproiete
Copy link
Member

Awesome! Thanks @Jericho

augustoproiete added a commit that referenced this issue Jan 25, 2023
@cake-contrib-bot @augustoproiete
Synchronize Contributors (#2508)
c74d9bb 
* (GH-2507) Create contributors.json
* (GH-2507) Create contributors.yml
* (GH-2507) Move contributors.* to /contributors

Co-authored-by: C. Augusto Proiete <augusto@proiete.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalberger pascalberger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Synchronize Contributors cake-contrib-bot/website
4 participants
@Jericho @augustoproiete @pascalberger @cake-contrib-bot