Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of ReSharperReports #557

Closed
gep13 opened this issue Jul 11, 2020 · 1 comment · Fixed by #558
Closed

Remove usage of ReSharperReports #557

gep13 opened this issue Jul 11, 2020 · 1 comment · Fixed by #558
Assignees
@gep13
Labels
Breaking change
Milestone
2.0.0

Comments

@gep13
Copy link
Member

gep13 commented Jul 11, 2020

This tool is currently used to convert the output from DupFinder into a report which can be easily viewed.

ReSharperReports can also convert the output from InspectCode into a viewable report as well, however, this is now handled by Cake.Issues.

There is a new addin for Cake.Issues, https://github.com/cake-contrib/Cake.Issues.DupFinder which will mean that Cake.Issues will also be able to work with DupFinder.

Due to this, and also the fact that there are no plans to make ReSharperReports run on .Net Core, I am going to suggest that we remove it, and bring in Cake.Issues addin when it is ready.
@gep13 gep13 added this to the 2.0.0 milestone Jul 11, 2020
@gep13 gep13 self-assigned this Jul 11, 2020
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 11, 2020
@gep13
(cake-contribGH-557) Remove usage of ReSharperReports
00532fa 
This will ultimately be replaced by new functionality in Cake.Issues.
@gep13 gep13 mentioned this issue Jul 11, 2020
Merged
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 11, 2020
@gep13
(cake-contribGH-557) Remove usage of ReSharperReports
d0e0449 
This will ultimately be replaced by new functionality in Cake.Issues.
AdmiringWorm added a commit that referenced this issue Jul 11, 2020
@AdmiringWorm
Merge pull request #558 from gep13/feature/GH-557
282a2a8 
(GH-557) Remove usage of ReSharperReports
@pascalberger
Copy link
Member

For reference: Upstream issue for having support for DupFinder in Cake.Issues.Recipe is cake-contrib/Cake.Issues.Recipe#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Breaking change
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-557) Remove usage of ReSharperReports gep13/Cake.Recipe
2 participants
@gep13 @pascalberger