Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cake version supported criteria to follow major versions #804

Closed
AdmiringWorm opened this issue Mar 1, 2021 · 1 comment
Closed
Milestone

Comments

@AdmiringWorm
Copy link
Member

Currently the criteria for checking if the cake version being used by the user is restricted to check if both major+minor versions of the tool is matching the one we build Cake.Recipe with.
This was done due to cake being in a pre 1.0 state and could include breaking changes in any minor release.

Now that cake have reached 1.0, this criteria should be updated to only factor in the major version of cake itself instead of the major+minor check already implemented.

Reference to the place that needs to be updated:

public bool IsSupportedCakeVersion(string supportedVersion, string currentVersion)
{
var twoPartSupported = Version.Parse(supportedVersion).ToString(2);
var twoPartCurrent = Version.Parse(currentVersion).ToString(2);
return twoPartCurrent == twoPartSupported;
}

@AdmiringWorm AdmiringWorm added this to the 3.0.0 milestone Mar 1, 2021
gep13 added a commit that referenced this issue Mar 22, 2021
Compare only the first (major) portion of the version number, rather
than the major/minor.
@gep13 gep13 closed this as completed Mar 22, 2021
@cake-contrib-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants