Add RedirectMiddleware #14384
Add RedirectMiddleware #14384
Conversation
| * @param \Psr\Http\Server\RequestHandlerInterface $handler The request handler. | ||
| * @return \Psr\Http\Message\ResponseInterface A response. | ||
| */ | ||
| public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface |
There was a problem hiding this comment.
Do we need a Middleware for this? Handling RedirectException seems like behavior we could build into ControllerFactory::invoke() or into Http/Server. If we handled it in Http/Server we would need to update the ErrorHandlerMiddleware to not swallow those errors which is a bit clunky and not idea in my opinion.
There was a problem hiding this comment.
I am also fine with that :)
This was just my first idea. And this way it is also opt-in.
There was a problem hiding this comment.
Throwing the exception from a component or controller class is another opt-in mechanism 😄
One drawback to handing RedirectException in the ControllerFactory is that RedirectExceptions raised in middleware won't work the same. Perhaps the ErrorHandlerMiddleware is the best place for these exceptions to be handled. It already handles lots of other kinds of exceptions, and this one has a pretty straightforward action to take.
Should we also expand the RedirectException to allow headers to be added?
There was a problem hiding this comment.
I am fine if someone draws up a better alternative PR.
An alternative to #14384. I've added a new RedirectException class that isn't coupled to Routing package and is integrated with the ErrorHandlerMiddleware which enables any middleware/controller/component to raise a RedirectException and get the intended effect.
|
With #14397 continuing this I will close this one. |
In 3.x we could use a hack with $reponse->send() and exit(); to make redirects from within the components and alike.
In 4.x this is not possible anymore, a cleaner approach is using the RedirectException available already.
But there is a core Middleware missing for handling this.
I added one on project level as demo here:
dereuromark/cakephp-sandbox@b4fb863
You can see how it can be used
https://sandbox.dereuromark.de/sandbox/search-examples/table?page=12 (200 OK)
But when you hit the next page usually, you get a hard exception
This is not very user-friendly, as often, just an item got deleted at the end and thus the page count is one less. So if userland code wants to easily implement a paginator that does this, such middleware is vital here.
https://sandbox.dereuromark.de/sandbox/search-examples/table?page=13 (302 redirect)
This one now redirects to the last page on its own.
With this change, it is easier inside apps to leverage the given exception now.