-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ignore or close] Minor js fix #989
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLserver big ints aren't as big as other database servers.
Conflicts: lib/Cake/Console/Command/Task/TestTask.php
This reverts commit 072991d.
Allow postLink() to support other HTTP methods; it defaults to POST
Remove redundant prefixing of APP to path. It's already done in CakeResponse::file()
2.3 fix rss test
Conflicts: lib/Cake/VERSION.txt
enable PluginDot for routeClass parameter
removing else statements and variables that are not needed. eg: return something(); vs $foo = something(); return $foo;
simplify the code in the string class
removing else statements and variables that are not needed. eg: return something(); vs $foo = something(); return $foo;
Fixed up some abreviated variables, removing extra long lines and removed variables that were not used.
this change did make wonky uuids
Simplify the code for sanitize class
simplify the code for object collection
…fields param array.
Add CakeTestCase::getMockForModel convenience method Fixes #3364
…e 'tag' option to 'false' for disable the wrapper.
Frameworks compatible Breadcrumbs.
prev() and next() methods of PaginatorHelper now possible to place the 'tag' option to 'false' for disable the wrapper.
Conflicts: lib/Cake/Console/Command/ConsoleShell.php lib/Cake/Network/CakeSocket.php lib/Cake/Network/Http/HttpResponse.php lib/Cake/Utility/Folder.php lib/Cake/View/MediaView.php lib/Cake/basics.php
fix coding standards
remove nonsense default value
Remove nonsense default value.
Add type hinting to dispatch filters. This should help provide more helpful errors when developers make mistakes.
Conflicts: lib/Cake/Test/Case/Model/ModelReadTest.php lib/Cake/Test/Case/View/MediaViewTest.php
it was duplicating many of the tests in CakeResponse, and missing a few of the cases in MediaView itself.
Conflicts: lib/Cake/View/Helper.php
URL string with # in should be routed Fixes #3400
to them, this way editors (NetBeans 7.3 for instance) stop marking them invalid.
Can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong, should by cakephp:23 instead of master