Port behavior from CakePHP in. #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cake\I18n\Time has this bizzarre behavior, and since I'd rather avoid causing possibly breaking changes I figured it made sense to add this here.
|
This is sad. |
|
I had removed that on purpose since it was not documented and made absolutely no sense |
|
@lorenzo Are we ok with there being a breaking change in 3.2 then? I'm also open to adding this goofy behavior into the CakePHP subclass. |
|
I would rather put the goofy behavior in the cakephp subclass than here. |
|
CakePHP subclass + some maybe a note that it must be removed for 4.0 then. |
|
@markstory I'm ok with either breaking or subclassing. I don't think the goofy behavior was actually documented |
|
Ok, moving to CakePHP subclass then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cake\I18n\Time has this bizarre behavior, and since I'd rather avoid causing possibly breaking changes I figured it made sense to add this here. Without this change we will end up failing ~10 tests in the TimeHelper suite.