Add DOMContentLoaded event alternative for Turbo #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Mar 22, 2024
webroot/js/inject-iframe.js
Outdated
|
|
||
| // Add support for turbo DOMContentLoaded alternative | ||
| // see https://turbo.hotwired.dev/reference/events#turbo%3Aload | ||
| doc.addEventListener('turbo:load', onReady, false); |
There was a problem hiding this comment.
This will close the toolbar and attach duplicate message handlers. I don't think that's what we want.
There was a problem hiding this comment.
Added a condition to set which of the two events to be used
Turbo ? 'turbo:load' : 'DOMContentLoaded';
|
Thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, the turbo:load event is added together with the already existing DOMContentLoaded event to avoid having to reload the page on each navigation.