Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin assets+url rewriting #484

Merged
merged 1 commit into from
Feb 12, 2013

Conversation

ravage84
Copy link
Member

@ravage84 ravage84 commented Feb 6, 2013

Hope you like this somewhat bigger patch for the docs.
I built the docs on my machine but I was experiencing a strange behaviour in the sidebar tree. I've added a new file to installation and now links to this new file appear on at least two places where they shouldn't (and aren't)!

  • Added note about handling plugin assets through Dispatcher is inefficient
  • Moved url rewriting to a separate file
  • Added a section about what if you can't use url rewriting
  • Improved core config section about App.baseUrl
  • Added section in deployment about improving performance due to symlinking
  • Removed parts of the blog tutorial (duplicated content)


Since handling static assets, such as images, Javascript and CSS files of plugins,
through the Dispatcher is incredibly inefficient, it is very recommended to symlink
them for production.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to give an example of how to do that here. An example of symlinking might be the easiest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rchavik
Copy link
Member

rchavik commented Feb 6, 2013

you could also symlink Plugin/webroot instead of creating links for each file.

ln -s app/Plugin/YourPlugin/webroot app/webroot/YourPlugin

@@ -72,241 +72,6 @@ get as a result of using the wrong delimiter, and it makes your
code more portable.


Apache and mod\_rewrite (and .htaccess)
=======================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to leave a link to the new page/file as there will be existing installs linking here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point but it feels a bit like dragging unneeded load.
That's the downside of not having a dedicated version of the docs for old releases. (i don't want to downplay the upsides)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicating the content isn't a good idea. Just a link would be fine 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't thinking of duplicating content, especially since I just removed some ;-)
Put the title back and and created a link "moved to..."

…ient

Moved url rewriting to a separate file
Added a section about what if you can't use url rewriting
Improved core config section about App.baseUrl
Added section in deployment about improving performance due to symlinking
Removed parts of the blog tutorial (duplicated content)

Fixed toctrees and a typo

deleted two .DS_Store files

Fixed broken commits
markstory added a commit that referenced this pull request Feb 12, 2013
@markstory markstory merged commit ce4cad3 into cakephp:master Feb 12, 2013
@ravage84 ravage84 deleted the plugin-assets+url-rewriting branch February 12, 2013 11:06
suzuki added a commit to suzuki/docs that referenced this pull request Jul 28, 2013
okonomi pushed a commit that referenced this pull request Jul 28, 2013
[ja] Follow up #484, #623 and more. follow up latest deployment.rst.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants