CS Cleanup #162
Merged
CS Cleanup #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth making a release (1.5.1) ? |
|
Probably because of hasIndexByName() which is using a wrong variable. |
| @@ -60,7 +60,7 @@ public function templateData() | |||
|
|
|||
| $action = $this->detectAction($className); | |||
|
|
|||
| if ($action === null) { | |||
| if (empty($action)) { | |||
There was a problem hiding this comment.
See the signature of that method. It now returns an empty array instead of two different return types which is usually a bad thing and a code smell. Instead it should always return array.
In light of PHP7 and "never return more than a single one - or null as 2nd default is not acceptable anymore" this is a necessary change IMO.
|
I'll do the release for the fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup as follow up on #161