Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chainability for the setColumns call #1198

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Fix chainability for the setColumns call #1198

merged 1 commit into from
Oct 8, 2017

Conversation

Johnnyshaun
Copy link
Contributor

Table->setColumns() was not returning $this despite the documentation and thus was not chainable.

It's fixed :-)

@dereuromark dereuromark merged commit 2e83970 into cakephp:master Oct 8, 2017
@dereuromark
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereuromark dereuromark dereuromark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johnnyshaun @dereuromark