Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix box configuration to work with humbug/box #1522

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

jawngee
Copy link
Contributor

@jawngee jawngee commented Apr 20, 2019

With regards to #1520:

Considering humbug/box (https://github.com/humbug/box) is now the actively maintained app for building phars, I updated the box.json configuration so that working phars can be generated.

The existing box.json was not working at all as humbug/box excludes composer.json from the root unless you explicitly set a flag to tell it not to.

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #1522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1522   +/-   ##
=========================================
  Coverage     74.44%   74.44%           
  Complexity     1976     1976           
=========================================
  Files            54       54           
  Lines          5826     5826           
=========================================
  Hits           4337     4337           
  Misses         1489     1489

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce47bc...2dc8864. Read the comment docs.

@lorenzo
Copy link
Member

lorenzo commented Apr 25, 2019

Thanks!

@lorenzo lorenzo merged commit d3b5349 into cakephp:master Apr 25, 2019
@lorenzo
Copy link
Member

lorenzo commented Apr 25, 2019

What do you suggest our next step should be?

@theofidry
Copy link

theofidry commented May 17, 2019

Hello, just saw this issue after a report from a user:

  • There is some instructions to install phinx somewhere still referencing Box2
  • It is not clear where/how box is downloaded which makes confusing which Box version this configuration is used with
  • If you are running the latests versions of Box3, you should have a couple of recommendations regarding redundant configuration settings and you could probably trim it down even further by taking advantage of some new Box3 features, namely that most files can be inferred from the composer.json file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants