Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version #1653

Merged
merged 3 commits into from
Dec 12, 2019
Merged

remove version #1653

merged 3 commits into from
Dec 12, 2019

Conversation

dereuromark
Copy link
Member

We need to remove this version thingie
Without tooling/automation releasing otherwise is always by design error prone

@dereuromark
Copy link
Member Author

dereuromark commented Dec 12, 2019

Should we remove the
Test\Phinx\Console\Command\ListTest::testVersionInfo
part? Or read the current version somehow differently? E.g. composer lock installation data.

@garas
Copy link
Member

garas commented Dec 12, 2019

It could read and find itself in vendor/composer/installed.json.

But overall version doesn't add much value. I'd vote to remove any version related code.

composer info robmorgan/phinx is enough to find version for troubleshooting problems.

@dereuromark
Copy link
Member Author

@garas Tests are green now, good to go?

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1653 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1653      +/-   ##
============================================
+ Coverage     76.28%   76.33%   +0.04%     
- Complexity     1988     2001      +13     
============================================
  Files            57       57              
  Lines          5743     5759      +16     
============================================
+ Hits           4381     4396      +15     
- Misses         1362     1363       +1
Impacted Files Coverage Δ Complexity Δ
src/Phinx/Console/PhinxApplication.php 100% <100%> (ø) 5 <1> (-1) ⬇️
src/Phinx/Console/Command/Init.php 86.15% <0%> (+3.54%) 28% <0%> (+14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a0d37...c7777e0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants