Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding total run time to WL approach notebook and making small modifications #103

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

claalmve
Copy link
Contributor

@claalmve claalmve commented May 1, 2024

Adding text about overall runtimes for running a notebook from start to finish for warming levels notebooks. Additionally, this PR re-writes part of warming_levels_approach.ipynb to decrease the overall runtime for the whole notebook.

…ntime and adding text in the beginning to describe how long the nb should take
@claalmve claalmve changed the title Adding overall runtimes to difficult notebooks Upgrading WL notebook runtimes and adding overall runtime text to tops of notebooks May 1, 2024
@claalmve claalmve changed the title Upgrading WL notebook runtimes and adding overall runtime text to tops of notebooks Adding total run time to WL notebooks May 13, 2024
@claalmve claalmve changed the title Adding total run time to WL notebooks Adding total run time to WL approach notebook and making small modifications May 18, 2024
Expanding lat/lon params
@vicford vicford self-requested a review May 31, 2024 14:54
@vicford
Copy link
Contributor

vicford commented Jun 12, 2024

We need to be careful about how LOCA2 data is represented in the visualizing step, especially if it's a single point location because...
Screenshot 2024-06-12 at 5 22 37 PM

This is in the warming_levels_approach NB with climakitae PR #343. When you zoom in (substantially) it improves to show a bar plot of all LOCA2 simulations
Screenshot 2024-06-12 at 5 26 36 PM

Copy link
Contributor

@vicford vicford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, with default settings

  • cell 11 [the two two_degreees.sel(lat=my_lat, lon=my_lon, method='nearest')] is breaking because the two_degrees data doesn't have a lon dimension, only a double lat
    • i.e., two_degrees is 21900 days_from_center x 3 lat x 129 all_sims
    • dropping the squeeze from the cell above fixes this problem, however...
  • then getting this error on cell 18
    Screenshot 2024-06-12 at 5 40 56 PM

@vicford
Copy link
Contributor

vicford commented Jun 14, 2024

Side note, the initial loading step takes closer to 45-50 minutes for me, not 35.

@vicford
Copy link
Contributor

vicford commented Jun 14, 2024

So the notebook runs in entirity, BUT this ends up being 120+ rows of this....

Screenshot 2024-06-14 at 1 12 52 PM

@claalmve
Copy link
Contributor Author

So the notebook runs in entirity, BUT this ends up being 120+ rows of this....

Screenshot 2024-06-14 at 1 12 52 PM

Yeah, these plots are tricky for LOCA. This is technically expected (2x2 gridcells being visualized), but of course it is not that interpretable. I will keep the notebook defaults to a single gridcell with LOCA for run-time purposes, but I will work on making sure that the above images visualize as a 4xn grid instead in case a user does select an area of gridcells in their parameters instead.

@claalmve claalmve merged commit 0ecad1d into main Jun 20, 2024
@vicford vicford deleted the add-runtimes-diff-nb branch June 20, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants