Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma cleanup #560

Closed
vykster opened this issue May 9, 2022 · 10 comments
Closed

Figma cleanup #560

vykster opened this issue May 9, 2022 · 10 comments
Assignees
Labels
design UX/UI research and tasks: Figma

Comments

@vykster
Copy link
Member

vykster commented May 9, 2022

Sarah and India to review figma, think about design patterns and reorganize and rename components for a clean slate before our next design push.

@srhhnry
Copy link
Member

srhhnry commented May 13, 2022

  • Clean up screens and ensure they are all current
  • Rename individual screens to ensure they are current
  • Rename pages for clarity
  • Create archive
  • Create section for new design system screens
  • Translate XXL container designers to XL screens
  • Create additional small, medium, large screens as needed
  • Look up Figma plugins for one that maps distances to help with translation to dev
  • Account for Captcha on various screens (14px from bottom, button is 60x60 and 60x256 on hover)

@srhhnry
Copy link
Member

srhhnry commented May 23, 2022

@machikoyasuda Just started playing around with the Measure plugin on Figma and it's starting to make sense. I could see starting to do annotations based on those measurements as well. We should chat about what measurements are the most useful.

Edit: You can check px measurement between elements! The UI is a bit confusing but I was able to take measurements between elements in a way that seemed helpful

@srhhnry
Copy link
Member

srhhnry commented Jun 1, 2022

@machikoyasuda I added recaptcha to the mobile screens and while the behavior isn't great, I don't think it's a huge problem for now. With the addition of the stacked footer, at 14px from the bottom the recaptcha doesn't block the action button, which I think is the most important thing here. Added screens to show. Important question---does this also appear on desktop, and if so, where on the screen?

Image

@machikoyasuda
Copy link
Member

machikoyasuda commented Jun 1, 2022

@srhhnry Captcha shows up on the pages with forms: The Enrollment page.

image

image

(This is a screenshot from production, so it does not reflect the redesigned page)

@srhhnry
Copy link
Member

srhhnry commented Jun 2, 2022

Okay, did some digging, and have we explored hiding the badge? Found this on google's site:

Image

Hiding the badge is definitely preferable, since its only purpose seems to be to alert users that there is spam protection. I don't think we need that with our users and I can see the badge being very disruptive (especially on mobile).

@srhhnry
Copy link
Member

srhhnry commented Jun 2, 2022

Alternatively, does the badge float 14px above the device viewing area? Or is it attached to the bottom of whatever content is loaded on the page? On mobile we can have users scroll for the footer, which would push the badge down away from the action buttons, if its anchored to content. If the badge floats and is always on screen, I think we might want to go with the hidden option if possible. (If not possible then I'll dig a bit more into either pushing it up or switching it to the left side.)

@machikoyasuda
Copy link
Member

Okay, did some digging, and have we explored hiding the badge? Found this on google's site:

Image

Hiding the badge is definitely preferable, since its only purpose seems to be to alert users that there is spam protection. I don't think we need that with our users and I can see the badge being very disruptive (especially on mobile).

This is great! I had no idea. This seems preferable. We would have to add text to the form pages.

@srhhnry
Copy link
Member

srhhnry commented Jun 2, 2022

Yup! The extra text is the tradeoff. I'll mock it up, but I think it'll be okay.

@thekaveman
Copy link
Member

+ we need this text translated, but I'm fine with this direction!

I might suggest "This form is protected..." instead of "This site is protected..." to be more accurate? Not sure it matters.

@srhhnry
Copy link
Member

srhhnry commented Jun 3, 2022

Yeah, I think that makes sense. It's a deviation from the Google request, but I don't think that matters too much.

@srhhnry srhhnry closed this as completed Jun 15, 2022
Repository owner moved this from This Sprint (Month) to Done in Digital Services Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design UX/UI research and tasks: Figma
Projects
Archived in project
Development

No branches or pull requests

5 participants