Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Only deploy Dev if dev code has changed #115

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Sep 9, 2021

close #111

adds paths filter so this dev deploy workflow only runs if at least one file in the explicitly specified list is changed.

How to test this PR

Follow the instructions from #109

https://github.com/machikoyasuda/benefits/actions

I made 2 PRs - one PR that changes app code (a i18n copy file) and another that changes a /docs/ file.

Only the PR that made changes to app code triggered the Deploy Dev workflow:
image

image

… at least one file is outside the docs dir at the root of the repo
@machikoyasuda machikoyasuda changed the title fix(ci/dev): only deploy Dev if non-docs code has changed fix(ci/dev): make Dev deploy only if non-docs code has changed Sep 9, 2021
@thekaveman thekaveman added this to the September 2021 milestone Sep 20, 2021
@machikoyasuda machikoyasuda changed the title fix(ci/dev): make Dev deploy only if non-docs code has changed Only deploy dev if dev code has changed Sep 21, 2021
@machikoyasuda machikoyasuda changed the title Only deploy dev if dev code has changed Workflow: Only deploy dev if dev code has changed Sep 21, 2021
@machikoyasuda machikoyasuda changed the title Workflow: Only deploy dev if dev code has changed Workflow: Only deploy Dev if dev code has changed Sep 21, 2021
@machikoyasuda machikoyasuda marked this pull request as ready for review September 21, 2021 18:37
…les and directories that should trigger this action
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this feels cleaner. Nice!

@thekaveman thekaveman mentioned this pull request Sep 21, 2021
@machikoyasuda machikoyasuda merged commit a1950be into dev Sep 21, 2021
@machikoyasuda machikoyasuda deleted the 111-dev-action-config branch September 21, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent dev environment deploy for docs changes
2 participants