Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eligibility/form): custom validation message for index and confirm fields #2045

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Feat(eligibility/form): custom validation message for index and confirm fields #2045

merged 9 commits into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. feat(form): set custom validation message for Eligibility Confirm fields 

    event listeners on the inputs and form check validity and set a custom
message if the input is not valid.

the custom message is defined as a data attribute on the input element.
    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5283517 View commit details
    Browse the repository at this point in the history

  2. chore: remove unused error message dict 

    this should've been removed in #1022
    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    922673f View commit details
    Browse the repository at this point in the history

  3. test: add coverage of agency-specific forms 

    the data is such that would pass browser validation
    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a31da91 View commit details
    Browse the repository at this point in the history

  4. test: add assertions for form widget attributes

    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a2c15d8 View commit details
    Browse the repository at this point in the history

  5. refactor: remove adding change listeners from form fields 

    this behavior is not included in product requirements
    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1e5f7f7 View commit details
    Browse the repository at this point in the history

  6. refactor(form): use more reliable method of getting elements to validate 

    query for elements with the 'data-custom-validity' attribute instead of
trying to use form fields.

the eligibility index for example only has 1 field with 4 inputs.
    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a6c365d View commit details
    Browse the repository at this point in the history

  7. feat: set custom validation message for Eligibility Index fields

    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ead179b View commit details
    Browse the repository at this point in the history

  8. refactor(form): bind validation to form's button rather than the form

    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1721a44 View commit details
    Browse the repository at this point in the history

  9. refactor: use variable set on the form itself to enable custom validity 

    instead of specifying it in the template
    @angela-tran
    angela-tran committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ccff754 View commit details
    Browse the repository at this point in the history