Feat(eligibility/form): custom validation message for index and confirm fields #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
angela-tran
force-pushed
the
feat/custom-validity
branch
5 times, most recently
from
2058dbd
to
00c9e86
Compare
|
Side note: our Cypress tests were actually really helpful for this PR. They fail tests that encounter syntax errors, which caught regressions on pages that contain forms but don't need custom validation messages. 🎉 See GitHub Action runs: |
thekaveman
reviewed
Apr 24, 2024
angela-tran
changed the title
angela-tran
changed the title
angela-tran
force-pushed
the
feat/custom-validity
branch
from
59c4808
to
e0f296e
Compare
thekaveman
requested changes
Apr 25, 2024
|
Need to resolve conflicts |
angela-tran
force-pushed
the
feat/custom-validity
branch
from
f6ebcd1
to
eb2264a
Compare
thekaveman
requested changes
Apr 25, 2024
event listeners on the inputs and form check validity and set a custom message if the input is not valid. the custom message is defined as a data attribute on the input element.
this should've been removed in #1022
the data is such that would pass browser validation
this behavior is not included in product requirements
query for elements with the 'data-custom-validity' attribute instead of trying to use form fields. the eligibility index for example only has 1 field with 4 inputs.
instead of specifying it in the template
angela-tran
force-pushed
the
feat/custom-validity
branch
from
eb2264a
to
ccff754
Compare
|
Rebased on top of #2042 and waiting for it to be merged to minimize merge conflicts |
thekaveman
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Eligibility index
Confirming custom error messages:
Expand
| English (mobile) | Spanish (desktop - w/local edits to .po) |
|---|---|
 |
 |
Eligibility confirm
Confirming custom error messages:
Expand
| Format | English (mobile) | Spanish (desktop w/local edits to .po) |
|---|---|---|
sub missing MST |
 |
 |
sub missing SBMTD |
 |
 |
sub length MST |
 |
 |
sub length SBMTD |
 |
 |
sub mismatch MST |
 |
 |
sub mismatch SBMTD |
 |
 |
name missing MST |
 |
 |
name missing SBMTD |
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2012
Reviewing
Eligibility Index form
Eligibility Confirm form
Cases to try with
subfield (card number field):In all those cases, you should get a browser validation message that says "Please enter a X-digit number." where X is the number specific for the transit benefit (5 for MST Courtesy Card, 4 for SBMTD Reduced Fare Mobility ID). See #2012 (comment) for more context.
Cases to try with
namefield (last name field):In all those cases, you should get a browser validation message that says "Please enter your last name."
Screenshots
Expand