Implement healthcheck in Django #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we want to avoid the AWS healthcheck triggering a 400/404 in Django, causing an event log to Amplitude
new Django healthcheck will be called by AWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS ECS
/healthcheckcalls were going unanswered by the nginx server, and so Django was processing as Bad Request, triggering an event log into Amplitude and a bunch of unnecessary work.But since we want the AWS healthcheck to tell us if the Django app is up and running (and by implication, nginx and gunicorn), this PR introduces an explicit Django route with a simple healthcheck reply in favor of the current setup.