resolve changes to sendgrid.java that served only graas report #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owades
changed the title
unreasonableman
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
We are actually pretty close to making this class a very light-weight java API for sendgrid. It's kind of a separate project, but really what's missing is:
- changing name of map back to
blobMap - pass in a list of mime types instead of assuming
image\png - remove hardcoded sender, and instead use SendGrid.Builder approach to create and configure instances
Mostly just daydreaming, since we have all kinds of other stuff queued up
|
Created an issue :-) #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change broke LoadAgendyData test. Created an issue for SendGrid unit test.