Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3880] remove i18n for all <Meta> or figure out how to SSR #15354

Closed
PeerRich opened this issue Jun 6, 2024 · 15 comments
Closed

[CAL-3880] remove i18n for all <Meta> or figure out how to SSR #15354

PeerRich opened this issue Jun 6, 2024 · 15 comments
Labels
💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync 🙋🏻‍♂️help wanted Help from the community is appreciated i18n area: i18n, translations Medium priority Created by Linear-GitHub Sync
Milestone

Comments

@PeerRich
Copy link
Member

PeerRich commented Jun 6, 2024

we have a lot of key/string pairs in social media previews:

image

either option 1: we remove all t("no_meeting_found") etc. with  → "No meeting found" and enforce english for page titles

option 2: we figure out how to SSR the translations for Meta

CAL-3880

@dosubot dosubot bot added the i18n area: i18n, translations label Jun 6, 2024
@PeerRich PeerRich added this to the v4.2 milestone Jun 6, 2024
@PeerRich PeerRich changed the title remove i18n for all <Meta> or figure out how to SSR [CAL-3880] remove i18n for all <Meta> or figure out how to SSR Jun 6, 2024
@PeerRich PeerRich added 🙋🏻‍♂️help wanted Help from the community is appreciated Medium priority Created by Linear-GitHub Sync labels Jun 6, 2024
@PeerRich
Copy link
Member Author

PeerRich commented Jun 6, 2024

/bounty 20

Copy link

algora-pbc bot commented Jun 6, 2024

💎 $20 bounty • Cal.com, Inc.

Steps to solve:

  1. Submit work: Create a pull request including /claim #15354 in the PR body to claim the bounty
  2. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to calcom/cal.com!

Add a bountyShare on socials

@algora-pbc algora-pbc bot added the 💎 Bounty A bounty on Algora.io label Jun 6, 2024
@adithyaakrishna
Copy link
Contributor

adithyaakrishna commented Jun 6, 2024

/attempt

Algora profile Completed bounties Tech Active attempts Options
@adithyaakrishna 5 bounties from 1 project
JavaScript, TypeScript,
Go & more
Cancel attempt

@adithyaakrishna
Copy link
Contributor

@PeerRich IMO the easiest way would be to go with Option-1 but if we choose to go with option-2, we might have to use the locale param in the opengraph API along with SSR

@rohanjadhav05
Copy link

rohanjadhav05 commented Jun 9, 2024

/attempt

@akashMasih
Copy link

attempt #15354

@panzacoder
Copy link
Contributor

/attempt

@panzacoder
Copy link
Contributor

@PeerRich Could you provide an example of a link that is incorrectly SSRing for different locales? Or is it all pages and only for certain locales? It seems from a quick peruse of the i18n code that server-side translations are already enabled so this ticket seems a bit more nuanced than just "figuring out" SSR.

Thanks in advance for any clarity you can provide!

@keithwillcode keithwillcode modified the milestones: v4.2, v4.3 Jun 17, 2024
@ydv129
Copy link

ydv129 commented Jun 23, 2024

/attempt

2 similar comments
@dfordp
Copy link

dfordp commented Jun 25, 2024

/attempt

@ranjanmangla1
Copy link

/attempt

@keithwillcode keithwillcode modified the milestones: v4.3, v4.4 Jul 16, 2024
ChetanBhosale added a commit to ChetanBhosale/cal.com that referenced this issue Jul 21, 2024
@Suvendu-UI
Copy link

is it still open?

@Suvendu-UI
Copy link

Suvendu-UI commented Jul 24, 2024

/attempt #15354

1 similar comment
@snehalbaghel
Copy link

snehalbaghel commented Aug 3, 2024

/attempt #15354

@keithwillcode keithwillcode modified the milestones: v4.4, v4.5 Aug 19, 2024
@keithwillcode keithwillcode modified the milestones: v4.5, v4.6 Sep 15, 2024
@PeerRich PeerRich added the community Created by Linear-GitHub Sync label Sep 25, 2024
@arshad-muhammad
Copy link

@PeerRich since the issue is not closes yet i would like to work on this.

@PeerRich PeerRich closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment