-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAL-3880] remove i18n for all <Meta> or figure out how to SSR #15354
Comments
/bounty 20 |
💎 $20 bounty • Cal.com, Inc.Steps to solve:
Thank you for contributing to calcom/cal.com! |
/attempt
|
@PeerRich IMO the easiest way would be to go with Option-1 but if we choose to go with option-2, we might have to use the locale param in the opengraph API along with SSR |
/attempt Options |
attempt #15354 |
/attempt |
@PeerRich Could you provide an example of a link that is incorrectly SSRing for different locales? Or is it all pages and only for certain locales? It seems from a quick peruse of the i18n code that server-side translations are already enabled so this ticket seems a bit more nuanced than just "figuring out" SSR. Thanks in advance for any clarity you can provide! |
/attempt |
2 similar comments
/attempt |
/attempt |
is it still open? |
/attempt #15354 Options |
1 similar comment
/attempt #15354 Options |
@PeerRich since the issue is not closes yet i would like to work on this. |
we have a lot of key/string pairs in social media previews:
either option 1: we remove all t("no_meeting_found") etc. with → "No meeting found" and enforce english for page titles
option 2: we figure out how to SSR the translations for Meta
CAL-3880
The text was updated successfully, but these errors were encountered: