Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect timezone when using "Add to your calendar" #225

Closed
jimafisk opened this issue May 29, 2021 · 1 comment
Closed

Incorrect timezone when using "Add to your calendar" #225

jimafisk opened this issue May 29, 2021 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@jimafisk
Copy link

Issue Summary

If you click on the Google "G" icon in the "Add to your calendar" section of the booking confirmation page, it adds an event to your calendar in the wrong timezone.

There's a conversation with some examples here: https://github.com/calendso/calendso/issues/17#issuecomment-837160227. I just figured this was worth opening as a separate ticket since the original intent of that ticket was for general timezone support, which has been added, and that ticket is closed, which makes it easy to fall through the cracks.

Steps to Reproduce

  1. As a requester, select and date and pick a timezone
  2. Fill out your info and press "confirm"
  3. At the bottom of the "Booking confirmed" screen click the "G" icon
  4. The event that is added in Google Calendar has the incorrect time selected

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

I'm curious about the intent of the "Add to your calendar" functionality in general. It appears that an event (in the correct timezone) is already being added to the requester's calendar based on the email address they enter in step 2 above. Is this functionality provided to give the requester an option to add this event to a different calendar? I could see that being helpful, just need to fix the timezone discrepancy or this will likely lead to confusion. Thanks!

@jimafisk jimafisk added the 🐛 bug Something isn't working label May 29, 2021
@emrysal
Copy link
Contributor

emrysal commented May 29, 2021

I traced the origin of this bug to be an issue taking the UTC date query param, casting it to local time, then feeding it into the button URL as a casted UTC string; which was then taken by google calendar and made calendar time again.

PR opened that fixes this;

I'm curious about the intent of the "Add to your calendar" functionality in general. It appears that an event (in the correct timezone) is already being added to the requester's calendar based on the email address they enter in step 2 above. Is this functionality provided to give the requester an option to add this event to a different calendar? I could see that being helpful, just need to fix the timezone discrepancy or this will likely lead to confusion. Thanks!

When you have the Gmail calendar integration a Calendar event is created and the requester / invitee is added to the invite automatically. Due to the way Gmail works the event notification is then send to the requester that automatically creates a calendar event on the requester side.

This may or may not be the case for other clients, I am only scratching the surface in many, many tests. However, it is safe to assume that many clients are unable or unwilling to automatically add the event to the user Calendar, this is where this view helps out, giving multiple (ultimately all, with ICS support) download options.

As more calendar integrations / email notifications are being introduced (email notifications have only recently been built and are very much in early stages) this view continues to provide many ways of adding calendar items directly into the calendar. This is the purpose.

zomars pushed a commit that referenced this issue May 23, 2023
fixes:- https://secure.helpscout.net/conversation/2117165409/2395

How to test? 
Create an event type with custom inputs 
GET Request on /event-types end point


After:- 
<img width="1440" alt="Screenshot 2023-01-07 at 4 57 39 PM"
src="https://user-images.githubusercontent.com/53316345/211147930-1154f1ad-5309-4e9c-b2e0-164169717d47.png">

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants